-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.29] feat/cct-868: Subset of list command options marked as deprecated #3467
[1.29] feat/cct-868: Subset of list command options marked as deprecated #3467
Conversation
d76796d
to
91d325f
Compare
59fdbdc
to
cc3155f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The deprecation notices show in almost all the places, and --consumed
needs to be deprecated as well (so please handle that too).
I checked what we do already to deprecate command line options; it seems that
- in the
--help
option: a message such as "Deprecated, this option will be removed from the future major releases. " is prepended (yes) to the "help" text - in the man page: the text "Deprecated, this option will be removed in future major releases. " is prepended to the description of the option
So, as example how to apply them for the options here, I'll show what to do for the --available
option:
- in the cli:
self.parser.add_argument( "--available", action="store_true", help=_("deprecated, this option will be removed from the future major releases; " "show those subscriptions which are available"), )
- in the man page:
.TP .B --all Deprecated, this option will be removed in future major releases. Lists all possible subscriptions that have been purchased, even if they don't match the architecture of the system. This is used with the .B --available option.
Since all the changes in the Python part will require reformatting, don't forget to use the black
tool to reformat the code.
Let me know for more questions/doubts/etc.
* Options --available, --all, --ondate, --servicelevel --no-overlap --match-install, --pool-only, --afterdate were marked as deprecated in ListCommand definition of their help string. * The options were marked as deprecated in list command manuald page. CARD ID: cct-868
cc3155f
to
8afdbab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Will wait for QE verification before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the QE POV and the pre-verification PASSED, therefore, PR can be merged:)
Options
were marked as deprecated
in ListCommand definition of their help string.
The options were marked as deprecated in list command manuald page.